Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[AUD-1889] Fix notification drawer swipes on tab screens #1209

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

raymondjacobson
Copy link
Member

Description

Fixes 3 bugs having to do with swipe gestures:

  • Clicking tabs doesn't properly respect stack navigation the way swiping does (e.g. clicking tab Bump 0.21.17 #3 and swiping back pops the stack instead of switches tabs)
  • Navigating deeper into the stack from a tab screen no longer breaks the full screen swipe (this was because we wouldn't re-enable stack/drawer gestures after "pushing" stack -- leaving a tab screen)
  • Drawer navigator can be correctly swiped on base tab screens (see video).
  • Bonus bug -- fixes type error in useAppScreenOptions

The 3rd change is the biggest in the PR and it does have a major caveat:

react-native-gesture-handler will basically always take precedence over material top tabs. I actually think this is is good because the current behavior is non-deterministic. However, it just means that future usage of gesture handler needs to be a little bit context-aware of this patch. Hope others agree!!

Yay! Swiping is now very happy! ... on ios

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Test device

  • Feed => notifs => feed
  • Trending week => notifs => week trending
  • Trending week => trending month => notifs => trending month
  • Trending week => trending month => track => trending month => trending week
  • Explore => playlist => explore

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bloody legend mate

@raymondjacobson raymondjacobson merged commit ab5f3cd into main Apr 14, 2022
@raymondjacobson raymondjacobson deleted the rj-aud-1889 branch April 14, 2022 02:59
@sliptype sliptype mentioned this pull request Apr 29, 2022
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants