This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[AUD-1889] Fix notification drawer swipes on tab screens #1209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes 3 bugs having to do with swipe gestures:
The 3rd change is the biggest in the PR and it does have a major caveat:
react-native-gesture-handler will basically always take precedence over material top tabs. I actually think this is is good because the current behavior is non-deterministic. However, it just means that future usage of gesture handler needs to be a little bit context-aware of this patch. Hope others agree!!
Yay! Swiping is now very happy! ... on ios
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Test device
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.