Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[C-1311] Fix Collectibles #2114

Merged
merged 1 commit into from
Oct 10, 2022
Merged

[C-1311] Fix Collectibles #2114

merged 1 commit into from
Oct 10, 2022

Conversation

sliptype
Copy link
Contributor

Description

  • Collectibles failing to load on profiles without either solana nfts or ethereum nfts
  • Undo a perf change to prevent cache update when no collectibles exists. The result of this cache update is used to determine loading state on collectibles tab

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for fast fix

@sliptype sliptype merged commit c737535 into main Oct 10, 2022
@sliptype sliptype deleted the sk-c-1311-fix-collectibles branch October 10, 2022 22:34
audius-infra pushed a commit that referenced this pull request Oct 15, 2022
[5cd5d68] [C-1322] Android and general performance improvements (#2149) Sebastian Klingler
[f6ef033] [C-1341] Add notifications bottom tab screen (#2148) Dylan Jeffers
[9ddfe72] [C-1335] Upgrade and share typescript version (#2145) Dylan Jeffers
[b701102] [C-1336] Implement account drawer (#2146) Dylan Jeffers
[8587b3f] Add structured data and update head (#2131) Joseph Lee
[40ef3b7] [C-1317] Improve client startup tooling (#2140) Raymond Jacobson
[e09c6f9] Update new tables to allow drag to add to playlist (#2134) Kyle Shanks
[4633581] Bump ios (#2144) Sebastian Klingler
[f331426] Slow down $AUDIO page Stripe/Coinbase button animation speed (#2143) Marcus Pasell
[44916a5] [C-1291] Add base layout for navbar overhaul (#2139) Dylan Jeffers
[e85955c] Prepend audius url to share url (#2142) Sebastian Klingler
[068917e] Use Hermes for Android app C-1329 (#2130) nicoback2
[98f845c] [C-1327] Fix deep linking for tracks with diacritics (#2137) Sebastian Klingler
[0ec460f] [PAY-685] Update Stripe button to use approved brand assets (#2138) Marcus Pasell
[1b1a377] Refactor bottom-tab-bar (#2136) Dylan Jeffers
[9dbb11e] fix play bar buttons target (#2135) nicoback2
[9daba05] [C-1303][C-1304] Fix misc. profile layout issues (#2129) Raymond Jacobson
[04eb0c9] [C-1272] Fix Search UI jank (#2133) Sebastian Klingler
[feaa6f0] Bump react-screens to 3.17.0 to avoid crash on android (#2132) Sebastian Klingler
[db996e8] Remove old table components and rename new table components (#2126) Kyle Shanks
[92a2c7e] [C-1319] Fix native profile collectibles (#2127) Dylan Jeffers
[7a83f29] [C-1282] Remove followUser social action in profile reducer (#2121) Dylan Jeffers
[26de098] [C-1309] Fix playlists/collectibles not loading (#2125) Dylan Jeffers
[78dee89] Fix getState undefined when opening reopening app on android (#2123) Sebastian Klingler
[ef69b70] [C-1318] Revert "[C-1184] Fetch lineups after coming back online (#2083)" (#2122) Andrew Mendelsohn
[42efd1b] [PAY-457] Add Geofilter for Coinbase, Stripe (#2118) Marcus Pasell
[e413d9a] Bring back unhealthySlotDiffPlays (#2119) Dylan Jeffers
[fb96ea4] Fix favorites page filtering on old tables (#2120) Kyle Shanks
[cf73f53] Fix android build (#2113) Sebastian Klingler
[ebaa5d8] [C-1040] Remove extraneous mobile logs (#2107) Dylan Jeffers
[bc7e7b0] bump libs in web and common (#2117) nicoback2
[dc16dcb] bump libs 1.0.12 (#2116) nicoback2
[c737535] Undo change to prevent cache update when no collectibles (#2114) Sebastian Klingler
[b2764ba] Keep screen awake when confirming tip (#2103) nicoback2
[4b39ec1] fix pw clipping on mobile (#2102) nicoback2
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants