Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Bump react-screens to 3.17.0 to avoid crash on android #2132

Merged
merged 2 commits into from
Oct 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mobile/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ PODS:
- React-Core
- RNReanimated (1.13.4):
- React-Core
- RNScreens (3.16.0):
- RNScreens (3.17.0):
- React-Core
- React-RCTImage
- RNScrypt (1.2.1):
Expand Down Expand Up @@ -927,7 +927,7 @@ SPEC CHECKSUMS:
RNPermissions: 3e5bb8afd93c787681bbacbf54d586a6272ecc92
RNReactNativeHapticFeedback: 653a8c126a0f5e88ce15ffe280b3ff37e1fbb285
RNReanimated: c1b56d030d1616239861534d9adb531f8cffab68
RNScreens: ee31ecdf23fe81e93c74feaa086cf173d758ab58
RNScreens: 0df01424e9e0ed7827200d6ed1087ddd06c493f9
RNScrypt: 5090216bbf2ebb7baea2f42fdd26011dc2c4c7b1
RNSentry: fe878ca3982d7871e502ccbb90072fe764c8d07d
RNSVG: 551acb6562324b1d52a4e0758f7ca0ec234e278f
Expand Down
6 changes: 3 additions & 3 deletions packages/mobile/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/mobile/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"react-native-randombytes": "3.6.1",
"react-native-reanimated": "1.13.4",
"react-native-safe-area-context": "3.3.2",
"react-native-screens": "3.16.0",
"react-native-screens": "3.17.0",
"react-native-scrypt": "1.2.1",
"react-native-shadow-2": "6.0.1",
"react-native-static-server": "github:futurepress/react-native-static-server.git#034c04e7a2999ae11a799fb68266c94389fc61bf",
Expand Down
29 changes: 11 additions & 18 deletions packages/mobile/src/screens/profile-screen/CoverPhoto.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { WidthSizes } from '@audius/common'
import { BlurView } from '@react-native-community/blur'
import { Animated, Platform, StyleSheet } from 'react-native'
import { Animated, StyleSheet } from 'react-native'

import BadgeArtist from 'app/assets/images/badgeArtist.svg'
import { DynamicImage } from 'app/components/core'
Expand Down Expand Up @@ -67,23 +67,16 @@ export const CoverPhoto = ({ scrollY }: { scrollY?: Animated.Value }) => {
styles={{ root: styles.imageRoot, image: styles.image }}
resizeMode={isDefaultImage ? 'repeat' : undefined}
>
{/*
Disable blur on android because it causes a crash.
See https://github.com/software-mansion/react-native-screens/pull/1406
TODO: C-423 pull in new version of react screens when the fix is released
*/}
{Platform.OS === 'ios' ? (
<AnimatedBlurView
blurType={'dark'}
blurAmount={100}
style={[
{ ...StyleSheet.absoluteFillObject, zIndex: 2 },
scrollY
? { opacity: interpolateBlurViewOpacity(scrollY) }
: undefined
]}
/>
) : null}
<AnimatedBlurView
blurType={'dark'}
blurAmount={100}
style={[
{ ...StyleSheet.absoluteFillObject, zIndex: 2 },
scrollY
? { opacity: interpolateBlurViewOpacity(scrollY) }
: undefined
]}
/>
</DynamicImage>
{isArtist ? (
<Animated.View
Expand Down