This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[C-1351] Finalize mobile-nav-bar-overhaul #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjeffers
requested review from
sliptype,
nicoback2,
Kyle-Shanks and
raymondjacobson
raymondjacobson
approved these changes
Oct 18, 2022
| const IconNotificationn = useMemo( | ||
| () => | ||
| colorize(IconNotificationBase, { | ||
| // Bell.Group 1.Fill 1 |
| height: spacing(12), | ||
| width: spacing(12), | ||
| marginBottom: spacing(3) | ||
| height: spacing(12) + 2, |
There was a problem hiding this comment.
should we accept partial sizes instead of this?
There was a problem hiding this comment.
Yeah will do, it's cause border width, I wonder if there is a clear way to express that
| @@ -31,6 +31,7 @@ export const NotificationsScreen = () => { | |||
| text={messages.header} | |||
| icon={IconNotification} | |||
| iconProps={{ height: 28, width: 28 }} | |||
| styles={{ icon: { marginLeft: -1 } }} | |||
There was a problem hiding this comment.
how come this is necessary?
There was a problem hiding this comment.
Yeah it's weird, the icons have various widths, so this is an attempt to align each icon
audius-infra
pushed a commit
that referenced
this pull request
Oct 22, 2022
[7952185] Auto follow person who referred you upon sign up C-1300 (#2112) nicoback2 [d87645e] Fix connected eth wallets (#2161) Raymond Jacobson [84c13b7] [C-1352] Fix twitter deep link (#2159) Raymond Jacobson [ffdd74a] dont deep link oauth (#2158) nicoback2 [fd75bf0] add use rendering trace util (#2153) nicoback2 [1b18577] [Android] Some optimizations for lineup C-1348 (#2150) nicoback2 [36506fb] [C-1347] Improve navigation performance (#2155) Sebastian Klingler [e6d1db3] [C-1351] Finalize mobile-nav-bar-overhaul (#2156) Dylan Jeffers [780a7c2] [C-1345] redesign primary/secondary screens (#2152) Dylan Jeffers [c6bedda] Update collection tables to allow for default sorting (#2151) Kyle Shanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description