This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[C-1326] Fix open in app drawer to open the app properly #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,7 +119,8 @@ const AppRedirectPopover = ({ | |||
| const onClick = () => { | |||
| onBeforeClickApp() | |||
| const pathname = getPathname() | |||
| const newHref = `https://redirect.audius.co${APP_REDIRECT}${pathname}` | |||
| const newHref = `audius://${pathname}` | |||
There was a problem hiding this comment.
nice. this redirect.audius.co thing is super broken.
does this work if the app is not installed?
There was a problem hiding this comment.
No this doesn't work when the app isn't installed, I assume that's why we had the redirect thing?
dylanjeffers
approved these changes
Nov 19, 2022
| @@ -124,6 +124,9 @@ const NavigationContainer = (props: NavigationContainerProps) => { | |||
| } | |||
| }, | |||
| getStateFromPath: (path, options) => { | |||
| // Add leading slash if it is missing | |||
| if (path[0] !== '/') path = `/${path}` | |||
sliptype
added a commit
that referenced
this pull request
Nov 24, 2022
* Fix open in app drawer to open the app properly * Add redirect prefix * Don't show popover on landing page Co-authored-by: sliptype <sliptype@gmail.com>
audius-infra
pushed a commit
that referenced
this pull request
Nov 26, 2022
[1264e58] Bump ios version to 1.1.41, lint (#2308) Dylan Jeffers [8e88d8d] [C-1549] Fix mobile share-drawer (#2307) Dylan Jeffers [4acd94b] Bump ios (#2306) Sebastian Klingler [f489853] [C-1326] Fix open in app drawer to open the app properly (#2286) Kyle Shanks [1db362c] [C-1531] Remove open in app from landing page (#2304) Raymond Jacobson [67196b8] iOS fast follows (#2305) Sebastian Klingler [fed67d3] Fix edit images (#2302) Sebastian Klingler [2d17c4a] Bump android image size (#2301) Sebastian Klingler [b16413f] Can be faster (#2300) Raymond Jacobson [0ea02e5] Fix types (#2299) Sebastian Klingler [f02ad81] [C-1411] Fix reachability issues with new splash screen (#2298) Raymond Jacobson [9afd61c] Use navigation.navigate for search (#2297) Sebastian Klingler [996a451] [C-1404] Add initial mobile wallet-connect (#2294) Dylan Jeffers [8eba94e] [C-1427] Fix multiple issues with Collectibles on mobile (#2296) Sebastian Klingler [d776787] Improve mobile image fetching (#2295) Sebastian Klingler [d3eddcc] [C-1535] Add mobile-upload analytics, fix remix field (#2293) Dylan Jeffers [ab6ece8] [C-1411] Improve loading splash (#2289) Raymond Jacobson [9d9ac84] [C-1328] Add edit/delete track mobile overflow options (#2292) Dylan Jeffers [82aec6c] [C-1509] Add input-accessory-view (#2291) Dylan Jeffers [916ada5] Fix premium content types (#2290) Sebastian Klingler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the Open in app drawer to use deep link to open the mobile app properly
Dragons
May be some slight bugs using a different link, but appears to be working
How Has This Been Tested?
Manually tested
How will this change be monitored?
N/a
Feature Flags
N/A