Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Fix android search input style #2314

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix android search input style #2314

merged 2 commits into from
Nov 28, 2022

Conversation

sliptype
Copy link
Contributor

Description

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird how it's chill on iOS. Can you also check the filter inputs for favorites?

@sliptype
Copy link
Contributor Author

sliptype commented Nov 28, 2022

Weird how it's chill on iOS. Can you also check the filter inputs for favorites?

Yup that one is also huge. I was going to add the padding 0 in the TextInput component but that seems kinda risky, wdyt?

Edit: I just went ahead and did it, think it's fine

@sliptype sliptype merged commit 6efaeaa into main Nov 28, 2022
@sliptype sliptype deleted the sk-android-search-input branch November 28, 2022 20:14
sliptype added a commit that referenced this pull request Nov 28, 2022
* Style android search input

* Add padding 0 for all TextInputs
audius-infra pushed a commit that referenced this pull request Dec 3, 2022
[d64e1a9] [C-1553] Refactor token-dashboard sagas (#2340) Dylan Jeffers
[4553262] [C-1601][C-1602] Fix splash screen and status bars on android (#2339) Raymond Jacobson
[19eceec] Share to Instagram - Use dominant colors; generate sticker (#2335) nicoback2
[24d762d] hotfix-ff: Unify magic numbers (#2337) Marcus Pasell
[479f459] [C-1554] Add phantom connect + sign message flow (#2328) Dylan Jeffers
[045be0e] Disable input accessory on android (#2338) Raymond Jacobson
[678cfcf] Fix hidden track centering (#2336) Raymond Jacobson
[3ed3168] Fix react-native-threads on android (#2331) Dylan Jeffers
[2bed171] hotfix: Extra padding for BuyAudio flow (#2334) Marcus Pasell
[14e4dd8] [C-1597] Fix wallet images (#2333) Raymond Jacobson
[4b066ad] Update sitemaps (#2323) Joseph Lee
[44dd7bf] [C-1574] Update UI in mobile wallet connect flow (#2329) Raymond Jacobson
[254b205] [hotfix]: Location detection fix (#2330) Marcus Pasell
[22a965d] Null check image source (#2327) Sebastian Klingler
[20a132b] Update react native music control (#2326) Raymond Jacobson
[2998382] Fix mac build (#2321) Raymond Jacobson
[2957645] [C-1572] Add react-native-threads, dominantColors thread (#2324) Dylan Jeffers
[3c796b6] [QA-225] Fix flashing uploading track cover art (#2325) Dylan Jeffers
[7eb37f0] Finalize mobile-upload feature flag (#2322) Dylan Jeffers
[28bb6ef] [C-1565 C-1566 C-1567] Improve upload copy, colors (#2320) Dylan Jeffers
[8856dae] Always fetch content node images from cache (#2319) Raymond Jacobson
[e3f6389] Fix logged out offline startup (#2318) Raymond Jacobson
[ec5563f] [C-1550] Improve left-nav open/close animation (#2313) Dylan Jeffers
[9a5200b] [C-1559] Fix audio-breakdown-drawer (#2315) Dylan Jeffers
[0c190e1] [C-1548] Integrate native WalletConnect (#2310) Raymond Jacobson
[a6911a7] [QA-223] Close notification panel when clicking entity link (#2316) Marcus Pasell
[6efaeaa] Fix android search input style (#2314) Sebastian Klingler
[72e0d84] [C-1069] Use persistent queue for offline downloads (#2287) Andrew Mendelsohn
[88f5949] Update icons and display names (#2312) Sebastian Klingler
[3d667c3] add waves to ig video; increase quality (#2311) nicoback2
[cd9f805] [C-1357] Fix followers formatting on sign up (#2303) Raymond Jacobson
[306aa17] [C-1357] Fix followers formatting on sign up (#2303) Raymond Jacobson
[0e35f7c] Fix android double play (#2309) Sebastian Klingler
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants