This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
C-1606 C-1609 C-1610 Share to IG Story QA #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjeffers
approved these changes
Dec 7, 2022
| @@ -144,6 +144,13 @@ android { | |||
| compileSdkVersion rootProject.ext.compileSdkVersion | |||
| flavorDimensions "default" | |||
|
|
|||
| packagingOptions { | |||
There was a problem hiding this comment.
wild, whats the tldr here?
There was a problem hiding this comment.
Oh this was just to fix this issue where two of our packages included libc++_shared.so
| @@ -8,7 +8,7 @@ buildscript { | |||
| targetSdkVersion = 31 | |||
| castFrameworkVersion = "21.0.0" | |||
| ndkVersion = "21.4.7075529" | |||
| ffmpegKitPackage = "https-lts" | |||
| ffmpegKitPackage = "https-gpl-lts" | |||
There was a problem hiding this comment.
i guess this too? need GPL version for android?
There was a problem hiding this comment.
Yeah so we needed to use the libx264 encoder to produce the properly formatted video with H.264/AAC, which is included in the GPL version but not the regular one. then i also needed to add file:// (for some reason it was working without this in iOS, it's like a small print thing in the react-native-share docs)
| @@ -274,7 +273,7 @@ export const useShareToStory = ({ | |||
|
|
|||
| // Step 4: Put everything together and push to IG | |||
| const shareOptions = { | |||
| backgroundVideo: storyVideoPath, | |||
| backgroundVideo: `file://${storyVideoPath}`, | |||
sliptype
approved these changes
Dec 7, 2022
audius-infra
pushed a commit
that referenced
this pull request
Dec 10, 2022
[9a78b12] Expose SDK in client (#2368) Reed [b6bf15b] [C-1649] Reset libs on app start (#2374) Sebastian Klingler [a27f0f5] [C-1651] Update mobile connect-wallet ui (#2375) Dylan Jeffers [8ca59ba] [C-1650] Finalize solana-phone integration (#2366) Raymond Jacobson [576231d] lint feature enabled (#2373) Isaac Solo [b966fe3] [C-1563] Fetch and download all paginated track favorites (#2363) Andrew Mendelsohn [17c9248] Make default Table isEmptyRow (#2370) Reed [f90a081] Remove optimizely social feature for EM (#2371) Isaac Solo [8826421] [C-1628] Add metamask/rainbow mobile wallet-connect (#2365) Dylan Jeffers [7eaad19] [Share to IG] C-1637 C-1636 C-1635 QA - make text static size, make sticker static colors, align icon (#2364) nicoback2 [1373b30] Remove getTrackListens endpoint from audiusBackend (#2169) sabrina-kiam [1f6973f] Queue optimizations; batch action for tracks (#2362) Andrew Mendelsohn [533e57c] C-1606 C-1609 C-1610 Share to IG Story QA (#2359) nicoback2 [32cea4b] Fix (#2361) Michael Piazza [36a9755] [PAY-753][PAY-754] Ensure > 1 $AUDIO quoted before trying recovery (#2355) Marcus Pasell [06b7d0f] [C-1632] Queue tracks in favorited collections (#2357) Andrew Mendelsohn [c4117e5] [C-1633] Chunk track fetching for large playlists (#2358) Dylan Jeffers [9831e94] Update mobile upload for final release (#2350) Dylan Jeffers [98a3dc1] Add clear timeout (#2356) Raymond Jacobson [e328a52] [C-1595] Fix sign out (#2351) Raymond Jacobson [073f890] [PAY-739] Add view transactions button in Audio page (#2332) Reed [0efca5b] Fetch and store ablum art for oflfine downloads (#2317) Andrew Mendelsohn [cfdece2] [C-1626] Connect phantom wallet-connect with common sagas (#2353) Dylan Jeffers [ecb33cb] [C-1596] Fix android mobile-upload bugs (#2354) Dylan Jeffers [080bf84] [C-1624] Fix eager load (#2352) Raymond Jacobson [552497f] [C-1557] Add TikTok to CompleteProfileWithSocial on desktop (#2341) Sebastian Klingler [228b20e] fix crash share to ig (#2349) nicoback2 [a88e3f9] [C-1615] Fix android fullscreen modals (#2348) Dylan Jeffers [86a7c6e] Update TrackListItem styles to reduce the width of the artist name (#2347) Kyle Shanks [cb54bf4] update audius icon (#2345) nicoback2 [e7294dc] [C-1614] Move creativeCommons to common (#2346) Dylan Jeffers [f475daa] share to ig events (#2344) nicoback2 [5ddeadc] [C-1675][C-1555] Implement wallet-connect and wallet-adapter-protocol (#2343) Raymond Jacobson [b4688f2] Add loading screen w/ cancel function to Share to IG (#2342) nicoback2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Use showfreqs instead of showwaves for a different look (can revert)
-Fix Android not working
-Fix gradient being flaky
-Make loading faster
RPReplay_Final1670448130.mov
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.