This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-1457] Add amplitude analytics to chat features #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this change https://demo.audius.co/mjp-dms-amp |
piazzatron
approved these changes
Jun 21, 2023
packages/mobile/src/screens/chat-screen/ChatMessagePlaylist.tsx
Outdated
Show resolved
Hide resolved
| const users = useProxySelector( | ||
| (state) => getOtherChatUsers(state, currentChatId), | ||
| [currentChatId] | ||
| ) | ||
|
|
||
| // Explicitly define type as undefinable since users could be empty | ||
| const firstOtherUser: User | undefined = users[0] | ||
| const firstOtherUser = users[0] |
There was a problem hiding this comment.
Might be able to avoid the returntype with const firstOtherUser = users[0] as User | undefined
|
Preview this change https://demo.audius.co/mjp-dms-amp |
|
Preview this change https://demo.audius.co/mjp-dms-amp |
|
Preview this change https://demo.audius.co/mjp-dms-amp |
dylanjeffers
approved these changes
Jun 22, 2023
audius-infra
pushed a commit
that referenced
this pull request
Jun 24, 2023
[fe5fda4] Fix entity button widths (#3650) Dylan Jeffers [820e79e] Fix user profile always showing artist tabs (#3648) Dylan Jeffers [bc34b6f] [C-2697] Fix mobile playlist qa issues (#3638) Dylan Jeffers [3e8d7e8] Mobile chats recalculate container bottom on keyboard shown (#3644) Reed [39928cf] Bump app versions for full release (#3643) Reed [437e971] Update SDK to v3.0.3-beta.56 (#3641) Marcus Pasell [3e42cb2] [PAY-1526] Mobile chat reaction picker shadow (#3642) Reed [ab33206] Amplitude tracking for chat report abuse (#3639) Reed [6f570c6] Put playlist-artwork generation behind flag (#3640) Dylan Jeffers [2f1f40d] [C-2475] Add desktop favorites playlist tab (#3637) Dylan Jeffers [394cacb] [PAY-1516] Chat report abuse flow (#3636) Reed [82204ec] [C-2763] Fix desktop playlist qa issues (#3634) Dylan Jeffers [3912407] Implement OAuth Write Popup C-2664 (#3628) nicoback2 [7e13b54] [C-2783] Add terms of service link (#3635) Dylan Jeffers [bda6eeb] Refactor: extract reusable modal field component (#3631) Andrew Mendelsohn [c2a59dc] [PAY-1319] Fix emoji keyboard overlapping chat text input (#3629) Reed [14150ec] [C-2784] Refactor track page to use entity button (#3624) Dylan Jeffers [5a3e74e] [PAY-1457] Add amplitude analytics to chat features (#3627) Marcus Pasell [d1aee10] [PAY-1412] Reset player state on app load (#3632) Reed [965330c] [PAY-1191] Finesse keyboard enter/exit animations (#3633) Michael Piazza [c9c531e] Create grant upon making developer app (#3630) nicoback2 [a33de30] [PAY-1464] DMs: Go to chat after successful tip (#3625) Marcus Pasell [646a5eb] [PLAT-1015] Remove entity manager feature flag (#3619) Raymond Jacobson [31450e7] [PAY-1498][PAY-1477] Misc mobile DMs UI Fixes (#3626) Michael Piazza [a08f3e7] [C-2760, C-2779] Fix header for playlist and artists tabs in explore screen (#3579) Kyle Shanks [9a98157] [C-2676] Rough release date modal (#3610) Andrew Mendelsohn [5e9a847] [C-2771, C-2772] Add duplicate add to playlist confirmation drawer and modal (#3601) Kyle Shanks [49ca553] [PAY-1468] Fix mobile chats copy message button (#3623) Reed [193ae1c] [PAY-1483] Patch RN to fix textinput multiline onchange not firing (#3622) Reed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds amplitude analytics to chat features.
TODO:
To make this work:
reportToSentryto contextmake()that mirrors thepackages/mobilemake()fn to contextAlso adds a fix that ensures
otherUseris definedDragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
Might be excessive on the reporting to sentry, given we already catch and report console.errors. Also, some errors are to be expected, and it will be hard to differentiate.
Didn't log any details about the messages to protect privacy. Not even track or playlist ids from unfurls. However, on error, I logged the href
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Not tested
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.