This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Migrate getDogEarType to common
#3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this change https://demo.audius.co/rt-dog-ear-common |
dylanjeffers
approved these changes
Jun 30, 2023
| premiumConditions?: Nullable<PremiumConditions> | ||
| } | ||
|
|
||
| export const getDogEarType = ({ |
There was a problem hiding this comment.
Since we also have dog ear for collections, can we specify this to either handle both, or just say this is track related?
There was a problem hiding this comment.
I think this already handles both - correct me if I'm wrong but I grepped DogEar in web and I believe I've changed every instance. Only saw one collection-related instance on CollectionPage that was only used for HIDDEN so that case is covered.
Maybe I should just change the file name to dogEarUtils.ts.
| @@ -263,23 +256,12 @@ export const DetailsTile = ({ | |||
| }, [onPressPlay]) | |||
|
|
|||
| const renderDogEar = () => { | |||
| const showPremiumDogEar = | |||
There was a problem hiding this comment.
Really smart not having to duplicate this everywhere!
schottra
approved these changes
Jul 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dogEarTypelogic was getting hairy and also we were doing the same calculations in every component that used aDogEar. Moved to a util fn incommonand updated all the callsites.getDogEarTypeshould now return null if there's not an exact match on the conditions, which also makes it possible to delete all theshowPremiumContentvars too.Dragons
How Has This Been Tested?
Local ios + web stage
There are probably some cases that I've missed but I think it's ok.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.