This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Mobile gated content updates pt. 2 #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this change https://demo.audius.co/rt-gated |
schottra
reviewed
Jul 3, 2023
| checkIcon: { | ||
| width: spacing(6), | ||
| height: spacing(6) | ||
| lineHeight: typography.fontSize.medium * 1.3 |
There was a problem hiding this comment.
oof, would be nice to get the typography stuff into mobile as well? Shouldn't need to set line heights manually...
There was a problem hiding this comment.
totally agree but out of scope for now!
schottra
approved these changes
Jul 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd missed some subtle margin changes to the gated content track screen.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Local ios stage - also tested locked content drawer
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.