-
Notifications
You must be signed in to change notification settings - Fork 43
Remove gated content feature flags from mobile #3726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking on this cleanup!! Looks great
packages/mobile/src/screens/edit-track-screen/screens/RemixSettingsScreen.tsx
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/screens/RemixSettingsScreen.tsx
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/screens/TrackAvailabilityScreen.tsx
Outdated
Show resolved
Hide resolved
packages/mobile/src/screens/edit-track-screen/fields/TrackVisibilityField.tsx
Show resolved
Hide resolved
I think name of PR is wrong though :) |
Preview this change https://demo.audius.co/rt-flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this taking into account that we still want the feature flags on iOS?
also nit: useIsGatedContentEnabled
is twice on the PR description
Turns out we only use those in the upload flow, don't filter out tracks in lineup. Had a discussion with @piazzatron on slack and we decided to just delete, since they don't really do what we want anyway. |
Description
Removes all usages of
useIsGatedContentEnabled
,useIsSpecialAccessEnabled
,useIsCollectibleGatedEnabled
from mobile.Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Local ios stage - tested track tiles, lineup tiles, upload flow
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.