Add npm run clean script

[dharit-tan]

Description

I find myself wanting to blast all node_modules and build folders frequently, this would make it easier.

Dragons

• is it sketch to have rm -rf in a script?
• Could not figure out where the build folder for web lives.
• This won't do everything that an npm run clean in mobile will but that's ok.

How Has This Been Tested?

Ran locally followed by npm i.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

[dylanjeffers]

personally im not the biggest fan of actively encouraging that workflow. i personally haven't had to blast modules in months. if we do want to go forward with something like this though, maybe update it to do rm -rf packages/*/node_modules ?

[dylanjeffers]

maybe another option is to add a "clean" method to each sub package so it's not all or nothing?

[raymondjacobson]

web is

build, build-staging, and build-production

[dharit-tan]

maybe another option is to add a "clean" method to each sub package so it's not all or nothing?

I guess I run into it more with mobile, bc I want to blast mobile, common, and then also have to blast web sometimes due to web common.

[rickyrombo]

Personally I would expect clean as only meaning build artifacts, not node_modules, so maybe better to have separate npm run clean and npm run clean:modules or something? The former should probably call upon the mobile npm run clean script rather than manually doing rm -rfs imo? can do react-native clean-project-auto to avoid interactive element: https://www.npmjs.com/package/react-native-clean-project

[rickyrombo]

I also echo doing rm -rf node_modules & rm -rf packages/*/node_modules rather than any cds

[dharit-tan]

Personally I would expect clean as only meaning build artifacts, not node_modules, so maybe better to have separate npm run clean and npm run clean:modules or something? The former should probably call upon the mobile npm run clean script rather than manually doing rm -rfs imo? can do react-native clean-project-auto to avoid interactive element: https://www.npmjs.com/package/react-native-clean-project

Good call - the auto doesn't include the brew update so that'll work. I like this idea.

[audius-infra]

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

[dylanjeffers]

dope!