-
Notifications
You must be signed in to change notification settings - Fork 43
[PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal #3874
Conversation
…ns, and use them in InboxUnavailableModal to pass the create chat action
Preview this change https://demo.audius.co/mjp-dms-share-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆♂️
packages/web/src/components/inbox-unavailable-modal/InboxUnavailableModal.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/inbox-unavailable-modal/InboxUnavailableModal.tsx
Outdated
Show resolved
Hide resolved
@@ -53,7 +58,7 @@ export const ChatHeader = forwardRef<HTMLDivElement, ChatHeaderProps>( | |||
ref | |||
) => { | |||
const dispatch = useDispatch() | |||
const [, setCreateChatVisible] = useModalState('CreateChat') | |||
const { onOpen: openCreateChatModal } = useCreateChatModal() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little weird that this is called onOpen
versus open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the same way about onClose
, should I change them to open
and close
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ye i think so, but ok if in sep pr for me
@@ -385,15 +391,12 @@ function* sendTipAsync() { | |||
yield* put( | |||
fetchPermissions({ userIds: [sender.user_id, recipient.user_id] }) | |||
) | |||
if (onSuccessConfirmedAction) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf this is wild
Preview this change https://demo.audius.co/mjp-dms-share-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicee LGTM! no need to make changes before merging but left some comments
Preview this change https://demo.audius.co/mjp-dms-share-2 |
[3436c20] [PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal (#3874) Marcus Pasell [a740243] Add sdk:update-hotfix (#3875) Dylan Jeffers [a25fd19] [C-2759] Make donation link external (#3872) Dylan Jeffers [15f056c] [PAY-1630] Wire up purchase content sagas (#3834) Randy Schott [998d44b] Fix mobile crash on drawer dismiss (#3871) Reed [7d0e0b3] [PAY-1430] "Leaving Audius" Warning for External Links (and createModal helper) (#3860) Marcus Pasell [bee8bd1] Remove .only on upload cypress test (#3869) Raymond Jacobson [4c0b25f] [C-2926] Implement selected values for upload contextual menu fields (#3848) Dylan Jeffers [5773578] Preserve CIDs for track and collection cover arts (#3866) Marcus Pasell [be0d278] [C-2930] Fix extra space after username in tip to unlock modal (#3845) nicoback2 [f5320be] QA-588 Fix collection card profile link (#3853) nicoback2 [360416e] Fix broken playlist fetch via resolve (#3863) Raymond Jacobson [2dc2c29] [PAY-1695] DMs: Entrypoint Analytics (#3862) Marcus Pasell [f80d366] Minor improvements to SEO flow merged in #3859 (#3861) Raymond Jacobson [b99d62f] Add nodes to env for SEO support (#3859) Raymond Jacobson [20476ee] [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858) Raymond Jacobson [7f79830] [C-2879] Add validation to single track upload flow (#3855) Kyle Shanks [6f4fc89] [C-2940] Update google analytics tags and fix embed build (#3856) Raymond Jacobson [3469c89] [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751) Dylan Jeffers
Description
Might be useful to look at commit by commit
CreateChatModal
to use thecreateModal
helper, making this easierInboxUnavailableModal
to usecreateModal
helper, making this easierSearchUserModal
to not take amodalName
etc and just acceptisOpen
onSuccess
andonSuccessConfirmed
which are used to navigate the user to the chat and create the chat respectively in the InboxUnavailable flow.Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested E2E on web against stage. Mobile has a slightly different impl, looking at that next and will try to unify
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.