Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Add lint check for console.log and remove some bad ones #3930

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Add lint check for console.log and remove some bad ones #3930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6c0473
Add lint check for console.log and remove some bad ones
raymondjacobson Aug 23, 2023
4bf33d6
Revert lockfile changes
raymondjacobson Aug 23, 2023
8c35413
Filter out debug and info logs from sentry
raymondjacobson Aug 23, 2023
04536b5
Fix common
raymondjacobson Aug 23, 2023
016d81d
Fix stems and embed
raymondjacobson Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ npm run stems

# common in watch mode
npm run common

# lint and typecheck
npm run verify
```

### Installing and Updating packages
Expand Down
50 changes: 25 additions & 25 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/eslint-config-audius/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ module.exports = {
'@typescript-eslint/no-redeclare': ['error'],

'no-use-before-define': 'off',
'no-console': ['error', { allow: ['debug', 'info', 'warn', 'error'] }],
camelcase: 'off',
'no-unused-vars': 'off',
'func-call-spacing': 'off',
Expand Down
80 changes: 40 additions & 40 deletions packages/mobile/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/mobile/src/app/useSyncCodepush.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const useSyncCodepush = () => {
}
},
(newStatus) => {
console.log('New CodePush Status: ', newStatus)
console.info('New CodePush Status: ', newStatus)
codePush.getUpdateMetadata(codePush.UpdateState.PENDING).then((res) => {
if (res != null && res.isMandatory) {
setIsPendingMandatoryCodePushUpdate(true)
Expand Down
2 changes: 0 additions & 2 deletions packages/mobile/src/components/collectible-details-drawer/CollectibleMedia.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ export const CollectibleMedia = (props: CollectibleMediaProps) => {

const VolumeIcon = isMuted ? IconMute : IconVolume

console.log(mediaType, imageUrl)

const renderByMediaType = {
// TODO: Implement 3D model viewing on mobile
[CollectibleMediaType.THREE_D]: () => (
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/src/components/details-tile/DetailsTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export const DetailsTile = ({
iconPosition='left'
icon={isPlaying ? IconPause : PlayIcon}
onPress={() => {
console.log('Preview button pressed')
console.info('Preview button pressed')
}}
disabled={!isPlayable}
fullWidth
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/src/components/rate-cta-drawer/RateCtaDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const RateCtaDrawer = () => {
// Do things after the popup shows up
})
.catch((error) => {
console.log(error)
console.error(error)
})
}
}, [])
Expand Down
Loading