Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Track creator node selection #90

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Oct 29, 2020

Trello Card Link

Description

Adds analytics for creator node selection. Eventually this CB should be passed to libs rather than used as it is here.
Link to dash: https://analytics.amplitude.com/audius/chart/ivqnd9r

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran against staging and prod & verified trigger of event on new creator & switching cns as old creator

@audius-infra
Copy link
Collaborator

Preview this change https://frontend-demo.audius.co/rj-record-cn-selection

Copy link
Contributor

@vicky-g vicky-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooooo I see, so everytime a primary or secondary is chosen, you track the number of times via amplitude

v nice

@raymondjacobson raymondjacobson merged commit 8eb49ed into master Oct 29, 2020
@raymondjacobson raymondjacobson deleted the rj-record-cn-selection branch October 29, 2020 18:50
sddioulde pushed a commit that referenced this pull request Sep 29, 2021
sliptype pushed a commit that referenced this pull request Feb 11, 2022
sliptype pushed a commit that referenced this pull request Feb 12, 2022
sliptype pushed a commit that referenced this pull request Feb 12, 2022
* Track creator node selection

* Add reason

* Update libs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants