Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secrets checks #8209

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix secrets checks #8209

merged 1 commit into from
Apr 24, 2024

Conversation

raymondjacobson
Copy link
Member

Description

Earlier this week I merged #8167, which made the git secrets tool only installed/updated in postinstall and then with @sddioulde merged #8182, which fixed that functionality.

As it turns out, now that we are properly running the secrets, the aws ones are buggy and yield a lot of false positives.
awslabs/git-secrets#208. Including flagging my recent few prs!

I pulled some secrets to add from here instead https://github.com/h33tlit/secret-regex-list

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

npm run postinstall
git secrets --scan --cached $(git diff --cached --name-only)

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 815d71c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Craziness, thank you for figuring this out!

@raymondjacobson raymondjacobson enabled auto-merge (squash) April 24, 2024 20:42
@raymondjacobson raymondjacobson merged commit 627c431 into main Apr 24, 2024
8 checks passed
@raymondjacobson raymondjacobson deleted the rj-secrets branch April 24, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants