Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backlog issues #525

Merged
merged 4 commits into from
Jan 9, 2018
Merged

Backlog issues #525

merged 4 commits into from
Jan 9, 2018

Conversation

nuevoalex
Copy link
Contributor

Nothing heavy impact, just the remaining backlog issues we had.

@nuevoalex nuevoalex requested review from bthaile and adrake33 January 8, 2018 23:19
Copy link
Contributor

@adrake33 adrake33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

function logFeeTokenMinted(IUniverse _universe, address _target, uint256 _amount) public returns (bool);
function logContractAddedToWhitelist(address _addition) public returns (bool);
function logContractAddedToRegistry(bytes32 _key, address _address, bytes20 _commitHash, bytes32 _bytecodeHash) public returns (bool);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs an extra carriage return at the end?


function getProtectedTokens() internal returns (address[] memory) {
return new address[](0);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@nuevoalex nuevoalex merged commit 7272124 into master Jan 9, 2018
@nuevoalex nuevoalex deleted the backlog_issues branch January 9, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants