Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup validation of settings not performed on reload #1190

Closed
ljacqu opened this issue Apr 30, 2017 · 2 comments
Closed

Startup validation of settings not performed on reload #1190

ljacqu opened this issue Apr 30, 2017 · 2 comments
Assignees
@ljacqu
Labels
Good first issue Marks issues that should be easy to fix/close, useful for new contributors. Type: enhancement
Milestone
5.4.0

Comments

@ljacqu
Copy link
Member

ljacqu commented Apr 30, 2017

We don't allow to set data source to Flat file anymore, nor do we allow the PLAINTEXT hash algorithm. On start up we notice such cases and perform a mandatory migration.

However, if such values are configured and a reload is performed, AuthMe accepts these values without batting an eye*. We need to perform the same validation as we do on startup in ReloadCommand.

* the data source cannot be changed on reload so flat file is not an issue
@sgdc3 sgdc3 added Good first issue Marks issues that should be easy to fix/close, useful for new contributors. Type: enhancement labels Apr 30, 2017
@ljacqu ljacqu added this to the 5.4 milestone May 9, 2017
@ljacqu ljacqu self-assigned this Oct 19, 2017
ljacqu added a commit that referenced this issue Oct 21, 2017
@ljacqu
#1190 Show settings warnings on reload also
95c12b9 
- Extract setting checks into their own class, called by Settings itself
ljacqu added a commit that referenced this issue Oct 28, 2017
@ljacqu
#1190 Show settings warnings on reload also
e57fdad 
- Extract setting checks into their own class, called on startup and reload
ljacqu added a commit that referenced this issue Oct 28, 2017
@ljacqu
#1190 Show settings warnings on reload also (#1384)
04c5224 
- Extract setting checks into their own class, called on startup and reload
@ljacqu
Copy link
Member Author

ljacqu commented Oct 28, 2017

Hi @HexelDev , OK to close this?

@hex3l
Copy link
Member

hex3l commented Oct 28, 2017

Yeah, well done ;)

@hex3l hex3l closed this as completed Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacqu ljacqu

Labels
Good first issue Marks issues that should be easy to fix/close, useful for new contributors. Type: enhancement
Milestone
5.4.0
Development

No branches or pull requests
3 participants
@hex3l @ljacqu @sgdc3