Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] tempban : try count not reset after minutesBeforeCounterReset minutes #1276

Closed
Spiikesan opened this issue Jul 8, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@Spiikesan
Copy link

Spiikesan commented Jul 8, 2017

What behaviour is observed:

My players gets banned from the server with only one login try, but I have
maxLoginTries: 3
in the config. Se same thing appears before with a limit of 10.
I have "minutesBeforeCounterReset: 10" but it doesn't work. The fail count is never reset.

What behaviour is expected:

The fail count to be reset and have 3 login tries as expected.

Steps/models to reproduce:

just /login with the wrong password.

Plugin list:

AutoSaveWorld, LuckPerms, WorldEdit, iDisguise, Essentials, EssentialsChat, Vault, EssentialsSpawn, ChatColor, ProtocolLib, WorldGuard, Multiverse-Core, SkinsRestorer, Orebfuscator4, Residence, EssentialsProtect, Multiverse-Inventories, AuthMe, VillageInfo, Multiverse-Portals, JSONAPI

Environment description

MySql on localhost.
Dedicated server.

AuthMe build number:

V5.3.2-SNAPSHOT (build: 1725)

Configuration:

https://pastebin.com/aE1C2829

@sgdc3 sgdc3 added the Type: bug label Jul 8, 2017
@sgdc3 sgdc3 added this to the 5.3.3 milestone Jul 8, 2017
@ljacqu ljacqu modified the milestones: 5.3.2, 5.3.3 Jul 8, 2017
@ljacqu ljacqu self-assigned this Jul 8, 2017
@ljacqu
Copy link
Member

ljacqu commented Jul 9, 2017

hi @Spiikesan , thanks for the report. We accidentally multiplied the configured minutes by 60'000, ouch :) This should be fixed with build n. 1737 or above, http://ci.xephi.fr/job/AuthMeReloaded/ We'd appreciate a quick reply to know if this can be closed.

@sgdc3
Copy link
Member

sgdc3 commented Jul 20, 2017

@Spiikesan bump

@ljacqu ljacqu closed this as completed Jul 23, 2017
@ljacqu ljacqu modified the milestones: 5.3.3, 5.4 Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants