Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FloatProperty #268

Closed
ljacqu opened this issue Jun 4, 2022 · 3 comments
Closed

Create FloatProperty #268

ljacqu opened this issue Jun 4, 2022 · 3 comments
Milestone
1.3.1 Release

Comments

@ljacqu
Copy link
Member

ljacqu commented Jun 4, 2022

Just like DoubleProperty, we should offer a FloatProperty.

  • Introduce FloatProperty
  • Check if other basic types would be useful
@zrdzn
Copy link
Contributor

zrdzn commented Jun 18, 2022 •
edited
Loading

Just like DoubleProperty, we should offer a FloatProperty.

  • Introduce FloatProperty
  • Check if other basic types would be useful

ShortProperty and LongProperty are also missing. These objects can be easily added because their primitive fields already exist in the PrimitivePropertyType class. I can pr this issue if it's not already in the works.

@ljacqu
Copy link
Member Author

ljacqu commented Jun 18, 2022

Long would definitely also be interesting. Short is fine by me. I probably wouldn‘t do char or byte though.
If you have time & interest, a PR would be greatly appreciated! 😄

@zrdzn
Copy link
Contributor

zrdzn commented Jun 18, 2022

#269

@ljacqu ljacqu added this to the 1.4.0 Release milestone Jun 28, 2022
@ljacqu ljacqu closed this as completed Jun 28, 2022
@ljacqu ljacqu modified the milestones: 1.4.0 Release, 1.3.1 Release Jun 20, 2023
ljacqu pushed a commit that referenced this issue Jun 20, 2023
@zrdzn @ljacqu
#268 Add LongProperty and ShortProperty
9b83180 
(cherry picked from commit ca3c6cb)
ljacqu added a commit that referenced this issue Jun 20, 2023
@ljacqu
#268 Add FloatProperty
2b51fcb
ljacqu added a commit that referenced this issue Jun 20, 2023
@ljacqu
#268 Add FloatProperty
bdc74e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
1.3.1 Release
Development

No branches or pull requests
2 participants
@ljacqu @zrdzn