-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No code highlighting with PHP language in code samples #197
Comments
Historically the php rendering has been broken in Prisma which is the library we are using (and really the only library). We can try turning it back on and seeing what will happen. Feel free to test out that change in a PR, if it works it works and we can merge it in. |
Indeed
Seems to be related to PrismJS/prism#1400 But simply adding I think the right approach now would be https://github.com/mAAdhaTTah/babel-plugin-prismjs as this project uses babel (Not going to spend any more time looking at this today) |
The real solution is in: PrismJS/prism#1400 And for prosparity, babel is only used for vanilla JS so this would not work everywhere, we needed a real solution. |
Example defined as:
I tried
PHP
andphp
Resulting render is as follows
As JavaScript has styling in the code block, I would expect other languages to also work?
I could be calling the language the wrong thing?
It could be only a subset of languages work?
Either way I suspect this is a bug, or a documentation change to make things clearer
The text was updated successfully, but these errors were encountered: