Added rings test functions #569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avcopan
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Andrea, this looks good! Thank you for working on this! It looks like we just need two small changes:
-
Either add back in the conftest.py file (see here) or define the data path like I do here. I had removed the conftest fixture because I wasn't sure how to use fixtures together with parametrized tests, so I didn't end up using it.
-
It looks like you need to adjust the thresholds on your call to
numpy.allclose. Specifically, I think you may need to set theatolto something like1e-5or1e-6. See here for documenation.
|
Thanks Andreas for the suggestions! I implemented both of them and am currently testing. As soon as the tests pass I will reopen the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for new functions related ro rings in geom/_ring.py