-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to temporarily switch theme/mode for e.g. today / Prepone activation on demand #439
Comments
IT'S HERE!!! UI Implementation in the app is still a work in progress, but the rest is available starting with 10.3.0.12 There are hotkeys as well as tray menustrip options Note: the feature we're tackling here is strictly postponing theme switch until the next day (next switch interval) |
Hi @Spiritreader, those a great news! Thanks for the update and working on this. Regarding the tray menustrip options: Besides the UI suggestion, I'm just not sure if things are working as they should for me on Windows 10 with v10.3.0.23 at all... 🙈
👍 |
Hey Tom, long time no see
I do understand the appeal of what you have proposed, but I will just remove the checkmark for the skip entry such that it behaves like the toggle button. The postpone menu entry is technically a toggle, so I will just keep the text changes instead.
Notification is only shown when using hotkeys. Haven't decided yet whether that will change.
They definitely are working like they should. It's just that how things work currently aren't correct for all scenarios. That one expires one second after the next theme switch trigger time. However as you've spotted correctly, when someone just wants to postpone the theme without switching, it needs to be moved ahead one more switch. Thanks for pointing that out, did miss that. Logic is the same on both OS versions. |
Always a pleasure to help with improving a great tool even further! ;)
As long as you remove the check mark when going for the toggle style it should remove potential confusion for users. 👍
Ahh, was not aware of that. When using hotkeys, the notification shows up on Windows 10 for me as well! Definitely looking forward to the next beta releases! |
Yea scratch what I said. I tried multiple options without the checkmark and that was even more confusing because it logically clashes with the auto switching entry above it. In addition, when auto theme switching is disabled, the pause/postpone entry now gets hidden. The logic oversight you pointed out is now fixed (turned out that was MUCH much worse and more difficult to get right than a bug could've ever been...) It now correctly detects the scenario of wanting to stay in the current theme by extending the postpone properly, but still keeps the toggle logic the same. New hotkey has also been added with a toggleable notification. And the postpone notification now shows when clicking on the context menu entry. I've consolidated all of those changes in a new build (10.3.0.28) |
- add new hotkey to toggle postpone - add logic for keeping current theme active for an entire day - inform user about postpone delay in tray / app / notification - fixed a bug where postpone timers were cancelled unexpectedly - fixed a bug where postpone timers would show incorrect values
There are no translation strings yet for the butons. This will come at some point in the future
Nothing will change in that regard. People will just have to use a bit of brain. |
After using it for a while, I like your solution and that you only add the day when it's not the same day. 👍 When following Windows night light, the tray menu uses the nice term |
I'm quite happy with where it's at right now, the version you're seeing is final. |
Just saying... Users that explicitly chose to use a dynamic event based on their location over a specific time value probably care about the sun, not the time. |
Hey @Spiritreader, I noticed the "Toggle theme" option here. I can't find any mention of it in other issues, commits or PRs, is it already implemented or is it being developed together with this feature request? |
Yes it's implemented and available in the latest beta versions of Auto Dark Mode. There's also a hotkey that's functionally the same and the shell commands (--swap, --light, --dark) were also updated. It was indeed developed alongside the postpone feature but part of the toggle code was already there from an older ADM version which has now been reworked into the new system. |
Awesome! Is stable 10.3.0 is releasing any time soon? |
The current beta version is the stable RC. Functionally they're the same. We're running a testing phase at the moment to ensure no unexpected behavior shows up |
Nice, thanks! |
Describe the enhancement or feature you'd like
![Untitled](https://user-images.githubusercontent.com/9874850/160099169-306bf673-a53d-47a1-bfb6-0e9e22d5569d.png)
There are only permanent toggle buttons which override your custom schedule. While there are use cases for this, there are other situations where one only wants to enable Dark Mode according to a specific environment they are currently working in.
It would be a great if the tool supports the user here and automatically goes back to his selected schedule.
It could be a combined button which temporarily enables the mode which is currently not running, e.g.
Enable Light/Dark Theme for Today
Enabling a certain mode until next (scheduled) execution would also describe the requested action.
Such a feature would basically prepone the planned schedule activation on request once, without altering the schedule itself and goes back to normal behavior on the selected times.
(BTW: If you want to take a screenshot, the enabled check marks in that menu never shop up in the screenshot on Win 10 😄)
The text was updated successfully, but these errors were encountered: