Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom script took too long to complete and had to be stopped #452

Closed
Tizoner opened this issue May 5, 2022 · 2 comments
Closed

Custom script took too long to complete and had to be stopped #452

Tizoner opened this issue May 5, 2022 · 2 comments
Labels
enhancement New feature or request question

Comments

@Tizoner
Copy link

Tizoner commented May 5, 2022

Question

Why TimeoutMillis from scripts.yaml is not being used in the AutoDarkModeSvc/Handlers/ScriptHandler.cs?
image
According to the service.log, custom script just does not have enough time to execute after reboot/sign out.
@Spiritreader Spiritreader added the enhancement New feature or request label May 5, 2022
Spiritreader added a commit that referenced this issue May 5, 2022
@Spiritreader
implements #452
e49b894
@Spiritreader
Copy link
Member

Spiritreader commented May 5, 2022 •
edited
Loading

Very good question.
I've fixed the issue, and also changed the timout behavior.
Timeouts now need to be set on a per-script basis.
This allows us to adjust the base value as needed, and also gives users better individual control over script maximum runtimes.

Please test it out and report back!
I've updated the wiki entry to reflect the changes.

@Tizoner
Copy link
Author

Tizoner commented May 5, 2022

It works, thank you!🎉

@Tizoner Tizoner closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Spiritreader @Tizoner