test(s3stream): add objectStorage rangeRead test #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
warr99
commented
Jun 14, 2024
warr99
commented
- Add AbstractObjectStorage close method
- rangeRead test
warr99
requested review from
superhx,
SCNieh,
ShadowySpirits and
Chillax-0v0
as code owners
superhx
reviewed
Jun 17, 2024
| abstract void doRangeRead(String path, long start, long end, CompletableFuture<ByteBuf> cf, Consumer<Throwable> failHandler, Consumer<CompositeByteBuf> successHandler); | ||
|
|
||
| abstract boolean isUnrecoverable(Throwable ex); | ||
|
|
||
| abstract void objectStorageClose(); |
There was a problem hiding this comment.
objectStorageClose => close0 or doClose
superhx
reviewed
Jun 17, 2024
|
|
||
|
|
||
| @Tag("S3Unit") | ||
| class ObjectStorageTest { |
There was a problem hiding this comment.
It should be AbstractObjectStrorageTest, and implement a mock AbstractObjectStorage
superhx
reviewed
Jun 17, 2024
| @@ -89,6 +89,19 @@ public AbstractObjectStorage( | |||
| S3StreamMetricsManager.registerInflightS3WriteQuotaSupplier(inflightWriteLimiter::availablePermits, currentIndex); | |||
| } | |||
|
|
|||
| // used for test only | |||
| public AbstractObjectStorage(boolean manualMergeRead) { | |||
There was a problem hiding this comment.
Prefer use a single base constructor and create a test constructor based on it. If there are many arguments in constructor, we could also use builder mode
superhx
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.