Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(s3stream): Avoid non-reuse TimerUtil object creation on write path #1447

Merged
merged 2 commits into from
Jun 20, 2024
Merged

perf(s3stream): Avoid non-reuse TimerUtil object creation on write path #1447

merged 2 commits into from
Jun 20, 2024

Conversation

lifepuzzlefun
Copy link
Contributor

No description provided.

@lifepuzzlefun
Copy link
Contributor Author

maybe a IOTraceContext pass through the write path is much better, but for current code one write request will create a lot TimerUtil, store to primitive may have better performance.

@SCNieh SCNieh merged commit 27018de into AutoMQ:main Jun 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SCNieh SCNieh SCNieh approved these changes

@superhx superhx Awaiting requested review from superhx superhx is a code owner

@ShadowySpirits ShadowySpirits Awaiting requested review from ShadowySpirits ShadowySpirits is a code owner

@Chillax-0v0 Chillax-0v0 Awaiting requested review from Chillax-0v0 Chillax-0v0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lifepuzzlefun @SCNieh