Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-resolution LBM Application #32

Merged
merged 27 commits into from
Feb 14, 2023
Merged

Multi-resolution LBM Application #32

merged 27 commits into from
Feb 14, 2023

Conversation

Ahdhn
Copy link
Collaborator

@Ahdhn Ahdhn commented Jan 13, 2023

No description provided.

@Ahdhn Ahdhn requested a review from massimim February 3, 2023 17:09
@Ahdhn Ahdhn marked this pull request as ready for review February 3, 2023 17:09
Copy link
Collaborator

@massimim massimim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The PR sounds good, I just left some minor comments.

Comment on lines +268 to +269
// Initiated by the fine level (hence "pull"), this function performs a coarse (level+1) to
// fine (level) communication or "explosion" by simply distributing copies of coarse grid onto the fine grid.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing the ordering schema for the levels to match the one used in tree structures, where the toot is a the level 0.

@Ahdhn Ahdhn merged commit 3b98084 into develop Feb 14, 2023
@Ahdhn Ahdhn deleted the MultiResLBM branch February 14, 2023 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants