Don't write camera aperture parameters if they're already set #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienblor
changed the title
cpichard
reviewed
Jun 26, 2024
| !cam.GetVerticalApertureAttr().HasAuthoredValue()) { | ||
|
|
||
| float fov = AiNodeGetFlt(node, AtString("fov")); | ||
| float horizontalAperature = tan(fov * AI_DTOR * 0.5f); |
There was a problem hiding this comment.
could be a good time to fix the typo horizontalAperature -> horizontalAperture
cpichard
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
In Maya USD exports, arnold is overwriting the aperture parameters to wrong values (internal ticket MTOA-1951).
Reason is that the arnold usd writer cannot set a correct aperture value since arnold cameras don't have this attribute, nor the focal length which would be needed to calculate it based on the fov.
Note that we had decided to author those values, even with an approximate value, because otherwise the exported cameras cannot be used in other usd tools.