-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: total number of organizations and teams #39
Conversation
newHeader, newData = self.parseData( | ||
self.executeQuery(self.query()) | ||
) | ||
self.header = newHeader if newHeader else self.header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.header
is not previously defined. Therefore, we would not set anything in the else part, right?
WHERE | ||
users.type = "Organization" | ||
AND | ||
users.login <> "github-enterprise" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We need to ignore this invalid organization in other reports, too. I think it would be easiest to hard code "github-enterprise" to https://github.com/Autodesk/hubble/blob/master/updater/reports/Report.py#L198-L210
//cc @pluehne ?
COUNT(*) AS count | ||
FROM | ||
teams | ||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that the total number of teams? Don't we want to know the number of teams per org here?
I dunno if we should mix that into this repo. @pluehne ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I hit "send", I realized you really want to count the total number of teams here 😄
Closed and continued in #43 |
This is a new history chart under ORGANIZATIONS