Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: total number of organizations and teams #39

Closed
wants to merge 1 commit into from
Closed

Chart: total number of organizations and teams #39

wants to merge 1 commit into from

Conversation

toddocon
Copy link
Contributor

This is a new history chart under ORGANIZATIONS

newHeader, newData = self.parseData(
self.executeQuery(self.query())
)
self.header = newHeader if newHeader else self.header
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.header is not previously defined. Therefore, we would not set anything in the else part, right?

WHERE
users.type = "Organization"
AND
users.login <> "github-enterprise"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We need to ignore this invalid organization in other reports, too. I think it would be easiest to hard code "github-enterprise" to https://github.com/Autodesk/hubble/blob/master/updater/reports/Report.py#L198-L210

//cc @pluehne ?

COUNT(*) AS count
FROM
teams
'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the total number of teams? Don't we want to know the number of teams per org here?
I dunno if we should mix that into this repo. @pluehne ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I hit "send", I realized you really want to count the total number of teams here 😄

@pluehne pluehne changed the title new chart for organization total and teams total Chart: total number of organizations and teams Nov 20, 2017
@larsxschneider
Copy link
Collaborator

Closed and continued in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants