Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup things I missed in the last PR #155

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Cleanup things I missed in the last PR #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/backend/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ def run_batch(data):
try:
#Running the Experiment
conduct_experiment(expId, expRef, experimentOutput, resultOutput, filepath, filetype, numExperimentsToRun)

# Post Processing
if postProcess:
print("Beginning post processing")
try:
Expand Down Expand Up @@ -153,7 +155,7 @@ def run_batch(data):
print(f'Experiment {expId} critical failure, not doing any result uploading or post processing')
logging.exception(err)
except Exception as err:
print(f'Uncaught exception "{err}," the GLADOS code needs to be changed to handle this, not doing any result uploading or post processing')
print(f'Uncaught exception "{err}," the GLADOS code needs to be changed to handle this in a cleaner manner')
logging.exception(err)
raise err
finally:
Expand Down
4 changes: 0 additions & 4 deletions apps/backend/modules/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ def run_trial(experiment_path, config_path, filetype, trialRun: int):
return get_data(process, trialRun)


# def run_trial_v2(trial: Trial):
# pass


def get_first_line_of_trial_results_csv(filename):
try:
with open(filename, mode='r', encoding="utf8") as file:
Expand Down