Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the old team's improperly ignored files #38

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

budak7273
Copy link
Member

  • Ignore .DS_Store files and remove tracked ones from the index
  • Remove old stuff that isn't relevant anymore from repo root .gitignore
  • Update .env.examples with new data
  • Untrack .env files that the previous team committed
  • Fix a few .gitignore duplicates
  • Un-ignore the .github folder (we want it for the workflow stuff)

When we locally modify .env files, it will no longer try to commit changes to them

- Remove old stuff that isn't relevant anymore from repo root .gitignore
- Update .env.examples with new data
- Untrack .env files that the previous team committed
- Fix a few .gitignore duplicates
- Un-ignore the .github folder (we want it for the workflow stuff)
Copy link
Member

@SpookyBeverage SpookyBeverage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@rhit-chanb rhit-chanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@budak7273 budak7273 merged commit 80d1266 into main Oct 19, 2022
@budak7273 budak7273 deleted the gitignore-env-fixes branch October 19, 2022 04:29
@budak7273 budak7273 self-assigned this Nov 10, 2022
@budak7273 budak7273 added this to the 10/20/2022 - Fall Wk7 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants