Fix PHP count() warning #534

mjangda · 2019-10-31T17:03:16Z

PHP Warning: count(): Parameter must be an array or an object that implements Countable

Switch to a another instance var that tracks the module count rather than trying to force the modules object into an array and back.

Fixes #498

To Test

Make sure you're using PHP 7.2 or newer and WP_DEBUG is set.
Goto /wp-admin/admin.php?page=ef-settings
Should see the warning.
Apply patch.
Refresh page and verify that error is gone and page renders correctly.

``` PHP Warning: count(): Parameter must be an array or an object that implements Countable ``` Switch to a another instance var that tracks the module count rather than trying to force the modules object into an array and back.

dchymko

Confirmed fixed in 7.2.

FYI this issue doesn't appear to occur in PHP 7.3.4

Fix PHP count() warning

e954944

``` PHP Warning: count(): Parameter must be an array or an object that implements Countable ``` Switch to a another instance var that tracks the module count rather than trying to force the modules object into an array and back.

mjangda added the [Status] Needs Review label Oct 31, 2019

mjangda requested a review from dchymko October 31, 2019 17:03

mjangda mentioned this pull request Oct 31, 2019

Fixed the php 7.2 count warning on the Settings page #503

Closed

dchymko approved these changes Oct 31, 2019

View reviewed changes

dchymko merged commit 259321a into master Oct 31, 2019

dchymko removed the [Status] Needs Review label Oct 31, 2019

GaryJones deleted the fix/php72-count-modules branch December 9, 2019 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PHP count() warning #534

Fix PHP count() warning #534

mjangda commented Oct 31, 2019

dchymko left a comment

Fix PHP count() warning #534

Fix PHP count() warning #534

Conversation

mjangda commented Oct 31, 2019

To Test

dchymko left a comment

Choose a reason for hiding this comment