Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WP Menu post title notice #552

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix WP Menu post title notice #552

merged 1 commit into from
Dec 12, 2019

Conversation

cojennin
Copy link
Contributor

@cojennin cojennin commented Nov 15, 2019

Fix for #551

display_post_states has two arguments, one of them $post (since WP 3.6). Use the argument instead of the global $post

@mjangda
Copy link
Member

mjangda commented Dec 2, 2019

As discussed: We should consider splitting this up into two separate PRs (the display_states_fix and em dash).

For the em dash, we should look to see if we can e2e tests.

@mjangda mjangda added this to the 0.9.3 milestone Dec 2, 2019
@cojennin cojennin changed the title Fix post title status shown/hidden Fix WP Menu post title notice Dec 5, 2019
Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test seems somewhat convoluted (might be easier just to test the filter more directly, i.e. apply_filters) but the patch fixes the reported issue, so 🚢

@cojennin cojennin merged commit 2b8f7b8 into master Dec 12, 2019
@cojennin cojennin deleted the fix/custom-status-title branch January 29, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants