Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'Customize' link in Metadata metabox to inside metabox #590

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Move 'Customize' link in Metadata metabox to inside metabox #590

merged 2 commits into from
Jan 30, 2020

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jan 28, 2020

Fixes #589

@jsit jsit requested a review from WPprodigy January 28, 2020 17:35
cojennin
cojennin approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@cojennin cojennin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jsit!

@cojennin
Copy link
Contributor

Merging. As @WPprodigy mentioned in #589

The proper fix here will be to drop the metabox in Gutenberg and have the UI built for the block editor.

But this looks good enough for the time being

@cojennin cojennin merged commit 4d8c651 into Automattic:master Jan 30, 2020
@cojennin cojennin mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojennin cojennin cojennin approved these changes

@WPprodigy WPprodigy Awaiting requested review from WPprodigy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML garbage in "Editorial Metadata" post screen options
2 participants
@jsit @cojennin