Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statuses for Story Budget and Calendar should be Edit Flow specific s… #595

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

cojennin
Copy link
Contributor

(#446) fixed an issue where Edit Flow was preventing other custom statuses from appearing in the status column for a post type, which makes sense.

However, for Calendar and Story Budget, you can end up with the following:

Screen Shot 2020-02-19 at 11 17 12 PM

These are statuses from WooCommerce in the Story Budget dropdown, and they persist even after the WooCommerce plugin is disabled. This makes the dropdown a little confusing (in this case, for folks who might have an e-commerce site with a content marketing arm that uses Edit Flow).

This PR cleans up some logic around the post status filters for Calendar and Story Budget, and also provides a way for folks to hook into Calendar and Story Budget status filers so folks can provide their own

@cojennin cojennin added this to the 0.9.5 milestone Feb 20, 2020
@cojennin cojennin force-pushed the fix/status-filter-dropdowns branch from 8c3d482 to 0438c2e Compare April 4, 2020 17:33
@cojennin cojennin force-pushed the fix/status-filter-dropdowns branch from 0438c2e to adeafe5 Compare April 4, 2020 17:39
@cojennin cojennin merged commit e708d9f into master Apr 4, 2020
@cojennin cojennin deleted the fix/status-filter-dropdowns branch April 11, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant