-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Optional pre-built translation files for popular languages #726
Comments
To offer under "Advanced Options" maybe? |
I find it a very good idea. I had a Brazilian Portuguese translation for an
older version and offered it to help, but one of the authors didn't want to
add it to the repo at the moment.
I understand that, but with an exclusive repo that would be a no-brainer.
|
Doesn't the .pot file generate string locations based on the line number of the template file? So if even a single line of the template file is added/removed, the translation file would need to be generated again by the user? |
That would be true, but it doesn't nullify the benefit of having a head
start.
|
If |
@jamigibbs When you change the structure or add new strings you have to regenerate the .pot file and whatever app you use to write out the actual translations will do its best to figure out what happened and remap all the translation files. I use Poedit for this and make a lot of changes that permeate through 17 different translation files without issues. The point of this proposal would be to provide developers with an already built-out starting point for translation files so each individual dev doesn't have to go out and source translations themselves. |
@mor10 the developers decided not to include translations (see #50), the argument being that _s is meant to be forked and changed, and so would the translatable strings; however I agree 100% it would be helpful to have starter translations that can be lightly edited rather than create from scratch. Other languages I've found so far:
If you're getting mentioned, please take a few minutes to refresh your translation to the current .pot and submit a pr to https://github.com/ptbello/_slated. |
Yes! This is great. I will submit a Norwegian translation presently. In medias res on my paranoid android
|
Great idea @ptbello, I'll pull my files of pt_PT. |
Is the .pot file synced with original _s.pot file? |
@pedro-mendonca yes, as of yesterday. And thanks for the pr |
There is a German translation from Caspar (@glueckpress) and Bernhard (@2ndkauboy): |
What about adding _s to https://translate.wordpress.org/projects? |
I don't think this is a good idea. _s isn't a framework. It's a starter theme. People are meant to add their own content and create their own theme. This right off makes any .pot included invalid and need to be regenerated. My main point against on top of this is maintenance. It's just something that would spiral. In saying this, if someone wanted to create a repo and have their own _s translations in it and do this for community - awesome. I do not see it as something in the scope of the _s project though. |
What @karmatosed says. Though arguably many strings never will be touched for customization during the average theme project, languages files in this repository would immediately raise the expectation that they’ll be well maintained. I don’t think that expectation would be met in the long run. Regarding @Zodiac1978’s example: My (outdated) German translation was found via Google search, forked, updated and a pull request was sent. Imo that’s how it should go with _s and translations. |
@karmatosed, @glueckpress I agree. |
@ptbello I was in the exact same situation as you. Luckily I found the (outdated) translation of @glueckpress before I was half way through. So I forked his repo, added the new strings and opened a PR. I can also understand why the I would even go a step further and would like to have a translation base with common string found in themes. Every theme will have a string e.g. "Oops! That page can't be found.", so why not have a translation database to get translation for such string. It would than be quite easy to build an up tp date translation file for For For the underscores.me I would than love to see a translation option in the advanched options view, so one can easily download a package including the proper (hopefully up to date) translation file. |
@2ndkauboy nice suggestions. |
@ptbello: I'll try to create the pull request later, when I return home. |
You'll have Farsi in _slated by tomorrow... |
@2ndkauboy merged, über cool! |
Closing this, as this _s related issue is resolved. |
This is just an idea: Many _s users probably don't make a lot of changes to the translated strings in the theme. I'm thinking it would be useful if there was some sort of repo where _s users could pull pre-built translation files for popular languages that could then be baked into their own custom themes. This should be relatively easy to build out and maintain and would encourage more theme developers to ship their themes with language support.
The text was updated successfully, but these errors were encountered: