Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Description #433

Closed
wants to merge 3 commits into from
Closed

Sidebar Description #433

wants to merge 3 commits into from

Conversation

emiluzelac
Copy link
Contributor

It would be nice to have a tiny sidebar description. They're very useful to users and one less worry for Theme authors :)

What do you think?

P.S. If in agreement we would need to update .pot as well.

It would be nice to have a tiny sidebar description. They're very useful to users and one less worry for Theme authors :)

What do you think?

P.S. If in agreement we would need to update .pot as well.
@obenland
Copy link
Member

I like the idea of adding the description argument here. Maybe we can come up with a better description?

@emiluzelac
Copy link
Contributor Author

I was thinking to leave that up to the Theme authors and just keep it short and sweet :)

@obenland
Copy link
Member

It would be an opportunity to describe the description. Main sidebar is somewhat misleading since we don't really have a secondary sidebar.

@emiluzelac
Copy link
Contributor Author

How's is that? I was debating between "Primary Sidebar" and "Appears in the sidebar". Second one makes more sense.

@karmatosed
Copy link
Contributor

I'm not sure about 'appears in the sidebar'. I do like the idea of Primary Sidebar as that makes sense.

Updated to Primary Sidebar, per #433
@emiluzelac
Copy link
Contributor Author

All set @karmatosed just updated to "Primary Sidebar".

@obenland
Copy link
Member

Main Sidebar and Primary Sidebar are acceptable names for a sidebar. They don't do much as to giving additional context though. Also, there is no secondary sidebar in _s.

I first thought that a meta description might make sense, something along the lines of:

Add a description to give your users an idea about the context in which this sidebar appears in.

This would add something that would have to be changed in every single theme though. Plus we don't do these kinds of meta descriptions a lot, outside of code comments. In content-none.php we encourage the enduser to write a post if there are none, that does not address the theme developer though.

In inc/custom-header.php we define default-image with an empty string instead of passing it an actual default image. It reflects the default value for this argument in add_theme_support() — maybe it would make sense to adopt that?

@emiluzelac
Copy link
Contributor Author

whatever you think is better :)

On Sun, Mar 30, 2014 at 1:24 PM, Konstantin Obenland <
notifications@github.com> wrote:

Main Sidebar and Primary Sidebar are acceptable names for a sidebar.
They don't do much as to giving additional context though. Also, there is
no secondary sidebar in _s.

I first thought that a meta description might make sense, something along
the lines of:

Add a description to give your users an idea about the context in which
this sidebar appears in.

This would add something that would have to be changed in every single
theme though. Plus we don't do these kinds of meta descriptions a lot,
outside of code comments. In content-none.php we encourage the enduser to
write a post if there are none, that does not address the theme developer
though.

In inc/custom-header.php we define default-image with an empty string
instead of passing it an actual default image. It reflects the default
value for this argument in add_theme_support() -- maybe it would make
sense to adopt that?

Reply to this email directly or view it on GitHubhttps://github.com//pull/433#issuecomment-39034317
.

@philiparthurmoore
Copy link
Collaborator

@obenland says:

In inc/custom-header.php we define default-image with an empty string instead of passing it an actual default image. It reflects the default value for this argument in add_theme_support() — maybe it would make sense to adopt that?

The empty default image is always funny to me. How many themes on .com are actually shipping with a default header image now? Or is it one of those things you find yourself removing a lot? (You don't have to answer this; it's neither here nor there.)

With regard to the issue at hand, I think you're spot on. An empty string would be more appropriate in register_sidebar as it's done in the custom header call.

@obenland obenland closed this in 32350a8 Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants