Optimize: _s_categorized_blog #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really care much about the returned; all we want is the count so there's no point in fetching all the category data.
We only need to know if there is more than one category so only fetch a maximum of two categories. The rest of the categories are all gravy.
obenland
added a commit
that referenced
this pull request
Mar 24, 2014
_s: Optimize `_s_categorized_blog()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the cool cats faster.
There are two small optimizations made here to
_s_categorized_blogto reduce the amount of data we fetch viaget_categoriessince the end result is just aboolvalue, which we can get with a pretty small subset.