Added 'on' prefix for hashchange event name in IE #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `attachEvent`, the event name needs an `'on'` prefix; see http://msdn.microsoft.com/en-us/library/ie/cc288209%28v=vs.85%29.aspx
|
Thanks for the Pull Request @jefferyto. We dropped support for IE8 around #218. If anything we should probably remove Feel free to open a new PR for that if you want to take that up. |
jefferyto
added a commit
to jefferyto/wordpress-_s
that referenced
this pull request
Apr 15, 2014
As noted in Automattic#456, IE8 is no longer supported. Also, undefined is falsey in JavaScript, so the typeof check was unnecessary.
|
Closing this in favour of #461. As a side note, it would be great if a list of supported browsers was available somewhere (readme, wiki, etc.). |
Added in 7cfc749. |
obenland
added a commit
that referenced
this pull request
Apr 15, 2014
Removed addEvent support. See #456.
CostyEffe
pushed a commit
to silverbackstudio/wp-theme
that referenced
this pull request
Jun 23, 2020
Better default composer options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
attachEvent, the event name needs an'on'prefix; see http://msdn.microsoft.com/en-us/library/ie/cc288209%28v=vs.85%29.aspx