Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting source code : 404.php #463

Merged
merged 1 commit into from
Apr 23, 2014

Conversation

gatespace
Copy link
Contributor

Add tab indent 404.php(L43 to L45).

@gatespace gatespace changed the title Formating source code : 404.php Formatting source code : 404.php Apr 18, 2014
@obenland
Copy link
Member

Thanks for the pull request @gatespace! Can you provide a little more detail on why you think this change is necessary?

@gatespace
Copy link
Contributor Author

Hi. @obenland .

For _s, PHP multiple lines is indented by a tab.
See line 27 to line 37 of 404.php.

I think _s should standardize the format.

@SeanTOSCD
Copy link
Contributor

I looked around more files when this PR was submitted. I do agree that @gatespace's change is the _s standard. I'm pretty sure this was the only place in the entire theme where multiple lines weren't indented.

obenland added a commit that referenced this pull request Apr 23, 2014
@obenland obenland merged commit e389dee into Automattic:master Apr 23, 2014
@gatespace gatespace deleted the formating-source-code branch April 24, 2014 03:28
CostyEffe pushed a commit to silverbackstudio/wp-theme that referenced this pull request Jun 23, 2020
*  ini_set() expects parameter 2 to be string

Uncaught TypeError: ini_set() expects parameter 2 to be string, int given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants