Removed vendor prefixes, except where it fixes a specific bug or quirk #561
Conversation
|
Why do we remove |
|
The rule on |
|
It's hard to read through your changes and know why you deleted the lines that you deleted. It would help if you could add supporting information into this Pull Request thread or directly on the lines that changed so that it's easier to understand why you took them out. |
|
@philiparthurmoore, the lines were removed due to them only being there to support browsers with very low market share (which may not have had such a low share at time of original authoring). This was discussed in issue #558 to lower the number of generated warnings. That's an overall view of the changes, but I will annotate each individually shortly. |
| @@ -77,8 +77,6 @@ html { | |||
| *, | |||
| *:before, | |||
| *:after { /* apply a natural box layout model to all elements; see http://www.paulirish.com/2012/box-sizing-border-box-ftw/ */ | |||
| -webkit-box-sizing: border-box; /* Not needed for modern webkit but still used by Blackberry Browser 7.0; see http://caniuse.com/#search=box-sizing */ | |||
There was a problem hiding this comment.
Removed due to low market share, less than 0.1%.
|
@mikemike Thank you very much. Sometimes it's hard to keep track of everything that's going on so the notes really help out. Cheers. |
| @@ -358,7 +356,6 @@ input[type="radio"] { | |||
| input[type="search"] { | |||
| -webkit-appearance: textfield; /* Addresses appearance set to searchfield in S5, Chrome */ | |||
| -webkit-box-sizing: content-box; /* Addresses box sizing set to border-box in S5, Chrome (include -moz to future-proof) */ | |||
| -moz-box-sizing: content-box; | |||
There was a problem hiding this comment.
Webkit vendor prefixes were kept here due to them fixing a bug/quirk in a relatively new browser whose market share is likely growing rather than shrinking. box-sizing is supported in Firefox without prefix since version 29.
|
@philiparthurmoore no, totally agree - much easier to read annotated code than an issue thread. Let me know if you disagree with any of the changes made. I have used best judgement, so people may wish to keep some of these, or remove others. |
|
my suggestion is to include WordPress' autoprefixer suggestions: |
Wasn't IE 6-8 support dropped? |
Also removes the box-sizing mixin, as it is of no use anymore. See http://caniuse.com/#feat=css3-boxsizing See #558. Fixes #561.
In reference to issue #558 (#558).
Some vendor prefixes remain, but only those that explicitly fix a bug or quirk on a device (there are 2 or 3 that fix bugs with the S5).