Inheriting box sizing v2 #641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operty changes in components and plugins that rely on other settings. For a more detailed explanation see http://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/ and http://blog.teamtreehouse.com/box-sizing-secret-simple-css-layouts#comment-50223
…operty changes in components and plugins that rely on other settings, now also with SASS. For a more detailed explanation see http://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/ and http://blog.teamtreehouse.com/box-sizing-secret-simple-css-layouts#comment-50223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New patch for inheriting box sizing (replaces the now closed #630). Removed my previous "unclean" patch and replaced with this one which only includes the actual changes, no historical data.
This patch is based on the same idea as #609 but also has a patch for SASS to make the two stylesheets consistent.
Background:
This patch improves box-sizing in accordance with http://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/ and http://blog.teamtreehouse.com/box-sizing-secret-simple-css-layouts#comment-50223 to allow for easier changes and alterations of the property in components and plugins that rely on other property settings.
Works the same as before, but improves functionality marginally and is considered the new best-practice approach.