Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbr needs text-decoration removed for FF. pre & abbr were styled in 2 places #942

Closed
wants to merge 1 commit into from

Conversation

andrewklimek
Copy link

abbr elements had double lines in Firefox because FF applies text-decoration: dotted and are the only browser supporting it.

@ghost
Copy link

ghost commented Apr 13, 2016

Personally I'd like to keep normalize.css untouched. (perhaps minus certain browser fixes if eventually automated)

@andrewklimek
Copy link
Author

Ok, I can see that. Maybe then remove the duplicate attributes from further down?

Either way the text-decoration: none for firefox would be a great reset addition.

@ghost
Copy link

ghost commented Apr 13, 2016

I believe the text decoration is actually there for a reason. It marks the existence of a title attribute. (similar to a link, but without the source)

The abbr tag needs to be updated though. I believe recent changes have been made here where they went for underline instead of border-bottom.

An update of _s' nomalize.css might be the best solution here. Unlike 98c86c2, #895 (comment)).

Simply over read it's previous reply #895 (comment).

I'm fine either way.

@philiparthurmoore
Copy link
Collaborator

Agreed that it'd be great if normalize were left as-is. It'll make it a lot easier to drop in updates when they happen.

@andrewklimek
Copy link
Author

Ok makes sense in that regard.

@andrewklimek andrewklimek deleted the patch-1 branch July 14, 2016 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants