Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ad Code Preview #40

Open
rinatkhaziev opened this issue Jun 28, 2012 · 15 comments
Open

Feature: Ad Code Preview #40

rinatkhaziev opened this issue Jun 28, 2012 · 15 comments
Assignees

Comments

@rinatkhaziev
Copy link
Contributor

This should be probably a row action which either pops an overlay with previews or displays them inline

@danielbachhuber
Copy link
Contributor

This would render the ad for preview?

@rinatkhaziev
Copy link
Contributor Author

Yep, that's what I was trying to say. I'll discuss with our designers, let's see what's their take on it. I envision modal window that shows all configured ad tag ids for specific ad code. (like, click preview in row actions, it pops the modal with all the different ad tags)

@danielbachhuber
Copy link
Contributor

Cool, that would be neat.

@ghost ghost assigned rinatkhaziev Oct 26, 2012
@rinatkhaziev
Copy link
Contributor Author

this one is mine for 0.4

@danielbachhuber
Copy link
Contributor

@rinatkhaziev still want to take a swing at this for v0.4?

@rinatkhaziev
Copy link
Contributor Author

@danielbachhuber Is there any tentative release date?

@danielbachhuber
Copy link
Contributor

@rinatkhaziev
Copy link
Contributor Author

@carldanley Can you look into this please? I think it'll take less for you time that it would've taken for me.
If not, I'll try to take care of it myself.

@carldanley
Copy link
Contributor

Sure, @rinatkhaziev. Is there more information concerning this modal and what it should look like? Has the 'preview' already been added? Just need a little more information to get started.

@rinatkhaziev
Copy link
Contributor Author

No requirements, but what I was envisioning is that when you hit a "Preview" row action it pops up a modal that renders all registered ad sizes. Rendering would happen in AJAX action. If you got a better idea - let's discuss it.
@jeremyfelt @carldanley @danielbachhuber

@carldanley
Copy link
Contributor

Will be able to look into this later this month. I'm heads down on a big site launch atm.

@danielbachhuber
Copy link
Contributor

Punting this to v0.5

@carldanley
Copy link
Contributor

Is there a mockup or anything for this? Was thinking I can use something similar to the new WP modal ( in terms of UI ). Thoughts?

@danielbachhuber
Copy link
Contributor

New WP modal sounds reasonable. There haven't been any mockups afaik

On Apr 16, 2013, at 5:11, Carl Danley notifications@github.com wrote:

Is there a mockup or anything for this? Was thinking I can use something similar to the new WP modal ( in terms of UI ). Thoughts?


Reply to this email directly or view it on GitHub.

@rinatkhaziev
Copy link
Contributor Author

Yes, there's no mocks. I can ask my UX/UI co-worker, but I agree with wp modal

@GaryJones GaryJones modified the milestones: 0.5.0, Future Release Mar 14, 2022
@GaryJones GaryJones removed this from the Future Release milestone Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants