Create a Book block #134
Merged
Create a Book block #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like a good idea to try to keep styles as consistent as possible.
`@wordpress/script env` was deprecated; on a fresh clone of this repo, the deprecation notice doesn't allow starting a new env unless we move to @wordpress/env.
|
Love it! Unless the other folks requested want to go with a code review more than I've done, I say let's get this in! |
|
I'll merge and we can revisit on future revisions! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes made to the the dependencies on another PR: #132 and it should land after. I considered both changes to be sufficiently different to require different discussions.
Add a Book block, with a caption that is specific to Book data, and a special placeholder for the cover image.
This is a building block for these future additions:
Preview