-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple Chatrix blocks on the same page or on different browser tabs #214
Conversation
This brakes the iframe build as the manifest gets picked up, somehow.
4252003
to
3402210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I am unclear on how to enable the feature flag though. I imagine, we would enable the feature flag for chatrix build and we would have it functional without making any changes in the settings. What am I missing?
The idea was that, for now, the user needs to go into Hydrogen's settings and enable the feature flag, since some things are broken, for example logout, and encrypted rooms, etc. Once we've address (some of?) these issues we can issue a new release with the feature flag enabled by default. Does that make sense? |
This PR brings in the changes from hydrogen related to "same session in multiple tabs" feature. The feature flag needs to be manually enabled through Settings, for now.
Enable feature flag
Open the same session in multiple tabs
feature flag