Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hyphenated adjectives marked wrong #107

Closed
Agent-E11 opened this issue Aug 9, 2024 · 3 comments
Closed

bug: hyphenated adjectives marked wrong #107

Agent-E11 opened this issue Aug 9, 2024 · 3 comments

Comments

@Agent-E11
Copy link

Now that "harper recognizes hyphenated words as single tokens", hyphenated adjectives are flagged:

short-term
first-time
long-distance
Spanish-speaking
sun-dried
second-place
four-wheel

I actually can't even think of any words that it doesn't flag. Even non-null, the example given in the release notes, doesn't work.

Personally, I prefer the old way, where it just checked the individual words.

@elijah-potter
Copy link
Collaborator

I actually entirely agree. I wanted to try the hyphenating "fix" for the sake of completeness, but there are simply too many combinations to add to the dictionary. I'll push out a release asap, undoing the change.

@elijah-potter
Copy link
Collaborator

I just want to say that I really appreciate your issues @Agent-E11. You've actually been a huge help. I've reverted the changes. As it turns out, pre should actually be it's own word, it just can only be used in certain grammatical contexts. As I mentioned in #101, if there are any other prefixes that should be added to Harper's dictionary, reopen the ticket and I'll make the changes.

@Agent-E11
Copy link
Author

Thanks 😄 I do really like this LSP by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants