Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenated words #101

Closed
Nukesor opened this issue Aug 6, 2024 · 4 comments
Closed

Hyphenated words #101

Nukesor opened this issue Aug 6, 2024 · 4 comments

Comments

@Nukesor
Copy link

Nukesor commented Aug 6, 2024

First of all, thanks for trying to tackle this problem :)

I played around a bit with harper and one issue I stumbled upon pretty quickly is hyphens.

For example, pre-existing is not in the dictionary, but it's also not possible to add it to the dictionary, as pre is detected as its own word.

It seems that there's currently no support for well-known hyphenated phrases.

@elijah-potter
Copy link
Collaborator

This should actually be a pretty quick and straightforward fix. I'll give an update here once a release is pushed out. Thanks for letting me know!

@elijah-potter
Copy link
Collaborator

The changes are made, but I am a little hesitant to create a release until the changes I've got stashed are finished. As before, I'll update here once it's truly ready.

@elijah-potter
Copy link
Collaborator

elijah-potter commented Aug 8, 2024

Alright there's a release with the tentative changes available now. Do me a favor and try out some other hyphenated words? We may need to expand the dictionary a bit. For example, I found that non-null was flagged as an error. I will need to do more work on this but would like a more comprehensive list.

@elijah-potter
Copy link
Collaborator

As per #107 this has turned out to be more complex. I've decided that the prefix should remain it's own token. These prefixes just need to be added to the dictionary as necessary. If there are any other prefixes that need to be added, please feel free to reopen this ticket and I'll make the changes promptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants