Move to stable rustc #186
Merged
Move to stable rustc #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit a simple `just check-rust` command which can be used to quickly check+lint the Rust parts of harper.
This commit adds a rust-toolchain.toml which helps maintain the compiler version across users. We don't pin the latest version, assuming that stable rust does not have too many breaking changes across versions. Although new clippy lints will always probably cause some problems.
In order to switch to a fully stable rustc, we need to remove the unstable rustmt options.
|
Looks good. It should shake out once it's been merged and formatted once more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
rust-toolchain.tomland switches the repo to use stable rust. This also adds ajust check-rustcommand which runs the rust-based lints.Previous discussion in #180
(commits are just for semantic separation, we should squash merge, or I can squash myself).