Skip to content

Commit

Permalink
Clean up some workarounds for old upstream bugs (#40199)
Browse files Browse the repository at this point in the history
* We no longer need to care about nanoid v3 thinking "browser === esm",
  because the GB package that had that dep no longer does.
* Various `jsx-a11y/label-has-associated-control` ignores referring to
  jsx-eslint/eslint-plugin-jsx-a11y#869 seem to be fixed now that #39736
  requires we use `htmlFor`. The one place still needing an ignore is
  jsx-eslint/eslint-plugin-jsx-a11y#578 instead.
* Remove reference to deleted renovate issue.
* Move reference to a Storybook bug to the code actually implementing
  the workaround.
* Update Storybook FAQ reference.
* Remove TODO references to a fixed Storybook bug (and fix a wrong prop
  in one story).
* Remove workaround for WordPress/WordPress-Coding-Standards#2390.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/11896972496

Upstream-Ref: Automattic/jetpack@62e385b
  • Loading branch information
anomiex authored and matticbot committed Nov 18, 2024
1 parent 87e0c0f commit 9d4cc18
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/contact-form/class-admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -1428,8 +1428,7 @@ public function grunion_recheck_queue() {
$query = 'post_type=feedback&post_status=publish';

if ( isset( $_POST['limit'] ) && isset( $_POST['offset'] ) ) {
// phpcs:ignore Generic.Strings.UnnecessaryStringConcat.Found -- Avoiding https://github.com/WordPress/WordPress-Coding-Standards/issues/2390
$query .= '&posts_per' . '_page=' . (int) $_POST['limit'] . '&offset=' . (int) $_POST['offset'];
$query .= '&posts_per_page=' . (int) $_POST['limit'] . '&offset=' . (int) $_POST['offset'];
}

$approved_feedbacks = get_posts( $query );
Expand Down

0 comments on commit 9d4cc18

Please sign in to comment.